profile: filter out bullet point when parsing failed units#16
Merged
pothos merged 1 commit intoflatcar-masterfrom Feb 1, 2021
Merged
profile: filter out bullet point when parsing failed units#16pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
The output of "systemctl list-units --state=failed --no-legend" still contains the bullet point which is not expected and ends up being taken as the unit name which was previously on the start of the line. Filter the bullet point out to stay compatible with the old behavior in case upstream would remove the bullet point again.
margamanterola
approved these changes
Feb 1, 2021
margamanterola
left a comment
There was a problem hiding this comment.
LGTM. I don't like this text parsing thing, but if we are doing it, we should do it right.
pothos
added a commit
that referenced
this pull request
Feb 1, 2021
profile: filter out bullet point when parsing failed units
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 1, 2021
This pulls in flatcar/baselayout#16 to fix parsing of failed units shown as motd.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 1, 2021
This pulls in flatcar/baselayout#16 to fix parsing of failed units shown as motd.
Member
Author
|
Picked for the |
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 1, 2021
This pulls in flatcar/baselayout#16 to fix parsing of failed units shown as motd.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 1, 2021
This pulls in flatcar/baselayout#16 to fix parsing of failed units shown as motd.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 1, 2021
This pulls in flatcar/baselayout#16 to fix parsing of failed units shown as motd.
|
Our latest stable version (2765) doesn't seem to have this fix :-/ |
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jun 1, 2021
…s for flatcar-2765 The output of "systemctl list-units --state=failed --no-legend" still contains the bullet point which is not expected and ends up being taken as the unit name which was previously on the start of the line. Filter the bullet point out to stay compatible with the old behavior in case upstream would remove the bullet point again. This pulls in flatcar/baselayout#16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of "systemctl list-units --state=failed --no-legend" still
contains the bullet point which is not expected and ends up being taken
as the unit name which was previously on the start of the line.
Filter the bullet point out to stay compatible with the old behavior in
case upstream would remove the bullet point again.
How to use
Log in to a system with a failed unit and see that now the unit name is printed while before it was just
Testing done
I manually ran the fixed version of the profile script to see that they now print the unit name as before