Merged
Conversation
|
I think we should also remove the explicit add in the other file if we do this. I don't think it leads to any errors having the user belong to a group through their GID and through an explicit add, but it's confusing and doesn't help. |
The tss GID is not 236 but 252. Luckily the tss group explicitly put the user into it but still we don't want an unallocated group to be used. While for consistency it would be nice to choose 236 as new GID, this could be incompatible with any files created under /var/ or a similar case where the old GID is still on the filesystem. With the correct GID referenced, the explicit add of the user inside the group file is not needed anymore.
Member
Author
|
Updated |
margamanterola
approved these changes
Jan 29, 2021
margamanterola
left a comment
There was a problem hiding this comment.
This LGTM. Since this is a very small cleanup, I'd not cherry pick it to stable and let it trickle through instead.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tss GID is not 236 but 252. Luckily the tss group explicitly put
the user into it but still we don't want an unallocated group to be
used. While for consistency it would be nice to choose 236 as new GID,
this could be incompatible with any files created under /var/ or a
similar case where the old GID is still on the filesystem. With the
correct GID referenced, the explicit add of the user inside the group
file is not needed anymore.
How to use
Testing done