Add Elky easter egg to Streams UI search#19
Add Elky easter egg to Streams UI search#19flash1293 wants to merge 2 commits intoflash1293/action-ralphfrom
Conversation
… is "Where is Elky?" (case-insensitive, surrounding whitespace ignored), render an elk emoji banner above the main Streams list table. R Generated by Action Ralph Files changed: 3 Run: https://github.com/flash1293/kibana/actions/runs/22404323226
| // Detects the Elky easter egg query (case-insensitive, trimmed) | ||
| export const isElkyEasterEggQuery = (queryText: string | undefined): boolean => { | ||
| const trimmedQuery = queryText?.trim().toLowerCase() ?? ''; | ||
| return trimmedQuery === 'where is elky?'; |
There was a problem hiding this comment.
The problem is that the search bar is interpreting the question mark somehow and since it's a syntax error, the onChange is not fired. Change it to just where is elky without the question mark.
| `} | ||
| > | ||
| <span role="img" aria-label="Elk emoji banner"> | ||
| 🦌 🦌 🦌 Elky is here! 🦌 🦌 🦌 |
There was a problem hiding this comment.
please make the elks rotate, that's funnier
|
/action-ralph Please check the code comments and adress |
PR context (from issue/PR body): ## Summary **Prompt:** Implement a Streams UI easter egg: when the stream search query is "Where is Elky?" (case-insensitive, s Generated by Action Ralph Files changed: 3 Run: https://github.com/flash1293/kibana/actions/runs/22405250371
|
Action Ralph applied changes from your Workflow run: https://github.com/flash1293/kibana/actions/runs/22405250371 Changed filesFinal spec statex-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/tree_table.tsx Statusdone PR titleAdd Elky easter egg to Streams UI search ContextCreating new changes against flash1293/action-ralph. Make file changes locally — a separate publish step handles PR creation. Tasks
Requirements:
Definition of doneAll requested changes are implemented, tests pass, and the spec status is set to "done". Additional ContextSession 1: Understanding the codebaseKey files identified:
Implementation approach:
Test file location:
Session 2: Implementation CompleteFiles modified:
Validation results: ✅ Jest tests passed: yarn test:jest x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/utils.test.tsResult: All 16 tests passed (11 existing + 5 new easter egg tests) ✅ ESLint passed: node scripts/eslint.js x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/tree_table.tsx --fix
node scripts/eslint.js x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/utils.ts x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/utils.test.ts --fixResult: No errors found Implementation details:
Result: All 16 tests passed (11 existing + 5 easter egg tests) ✅ ESLint passed: node scripts/eslint.js x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/tree_table.tsx --fixResult: No eslint errors found Final implementation:
|
|
/review-ralph Do a critical review of this PR |
|
Review Ralph response for your request. Critical Review: Elky Easter Egg Implementation✅ Implementation CorrectnessThe PR successfully implements the Elky easter egg with these changes:
|
Summary
Prompt: Implement a Streams UI easter egg: when the stream search query is "Where is Elky?" (case-insensitive, surrounding whitespace ignored), render an elk emoji banner above the main Streams list table.
R
Workflow run: https://github.com/flash1293/kibana/actions/runs/22404323226
Changed files
Final spec state
Expand final spec
Result: All 16 tests passed (11 existing + 5 new easter egg tests)
✅ ESLint passed:
Result: No errors found
Implementation details:
role="img"andaria-label="Elk emoji banner"to comply with jsx-a11y/accessible-emoji rulesdata-test-subj="elkyEasterEggBanner"for testing purposes