Ignore error from close first window after startup.#175
Merged
thshdw merged 1 commit intofitztrev:masterfrom Jun 3, 2016
mortonfox:iterm2-3-startup-dont-open-any-windows
Merged
Ignore error from close first window after startup.#175thshdw merged 1 commit intofitztrev:masterfrom mortonfox:iterm2-3-startup-dont-open-any-windows
thshdw merged 1 commit intofitztrev:masterfrom
mortonfox:iterm2-3-startup-dont-open-any-windows
Conversation
The problem is in iTerm2 3.0.0, when Preferences/General/Startup is set to "Don't Open Any Windows", it does not open a window when it starts up. So "close first window" fails with an error. To handle this scenario, we can simply wrap this statement in try / end try.
Collaborator
|
Hi @mortonfox good catch. This is not specific to v3 however. Thanks for taking the time to open a pull 👍 |
Closed
This was referenced Jun 20, 2016
Merged
thshdw
pushed a commit
that referenced
this pull request
Jul 24, 2016
Fixes for 1.2.7 * Corrected an issue where commas in commands would not be parsed. #173 * Changed the directive names for iTerm_version. Valid names are legacy, stable, nightly. #181 * Contains new icons by @pluwen #141 * Contains an apple script fix by @mortonfox where an iTerm setting would prevent scripts from running #175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is in iTerm2 3.0.0, when Preferences/General/Startup is set
to "Don't Open Any Windows", it does not open a window when it starts
up. So "close first window" fails with an error. To handle this
scenario, we can simply wrap this statement in try / end try.