fix: Preserve session_runner when restarting game session#971
Merged
MaxCWhitehead merged 2 commits intofishfolk:mainfrom Apr 14, 2024
Merged
fix: Preserve session_runner when restarting game session#971MaxCWhitehead merged 2 commits intofishfolk:mainfrom
MaxCWhitehead merged 2 commits intofishfolk:mainfrom
Conversation
zicklag
approved these changes
Apr 14, 2024
DRuppFv
pushed a commit
to DRuppFv/jumpy
that referenced
this pull request
Apr 20, 2024
For map transitions, a session command restarting game session will be used after updating map. This updates jumpy for related changes in: fishfolk/bones#384 We can restart a networked game session by calling restart on session runner, which handles existing socket + match id increment, implemented on the bones side. CI will fail until bones PR is merged + bones updated in lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For map transitions, a session command restarting game session will be used after updating map. This updates jumpy for related changes in: fishfolk/bones#384
We can restart a networked game session by calling restart on session runner, which handles existing socket + match id increment, implemented on the bones side.
CI will fail until bones PR is merged + bones updated in lockfile.