chore(build): use shadow-rs for build info#891
Merged
zicklag merged 2 commits intofishfolk:mainfrom Dec 23, 2023
Merged
Conversation
zicklag
approved these changes
Dec 23, 2023
Member
zicklag
left a comment
There was a problem hiding this comment.
The VERSION constant was apparently displaying multiple versions in like a YAML format, and also needed to be tweaked to return a &str so egui knows not to make it look like an editable textbox. I also needed to remove the default features in the non-build dependency so that it would build on WASM, but now everything looks good!
I also tested locally to make sure you could build with just a source snapshot and no git repository.
Member
|
Published v0.9.3 with this update. |
Member
Author
|
That's great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #890