-
Notifications
You must be signed in to change notification settings - Fork 128
Closed
Description
Description
#887 made the compilation hardly depend on the git binary. This blocks me from updating the Arch Linux package (since I'm not using the git repo for building, but the source archives):
error: git describe exited with status 128: fatal: not a git repository (or any of the parent directories): .git
--> src/ui/main_menu.rs:100:57
|
100 | egui::TextEdit::singleline(&mut git_version::git_version!())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this error originates in the macro `git_version::git_version` (in Nightly builds, run with -Z macro-backtrace for more info)
error: could not compile `jumpy` (bin "jumpy") due to previous errorThis can be verified from the git-version documentation:
These macros do not depend on libgit, but simply uses the git binary directly. So you must have git installed somewhere in your PATH.
To Reproduce
Build from source without Git.
Expected Behavior
Successful build.
Additional Context
I recommend using shadow-rs to conditionally embed the build info instead (in build.rs). e.g. use the git version if the git is installed, use the actual version otherwise.
Log Messages
Shared above.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels