feat: Allow local input to be disabled on SessionRunner.#411
Merged
MaxCWhitehead merged 3 commits intofishfolk:mainfrom Jun 9, 2024
Merged
feat: Allow local input to be disabled on SessionRunner.#411MaxCWhitehead merged 3 commits intofishfolk:mainfrom
MaxCWhitehead merged 3 commits intofishfolk:mainfrom
Conversation
github-merge-queue bot
pushed a commit
to fishfolk/jumpy
that referenced
this pull request
Jun 9, 2024
… continue running (#1003) Previously pausing in online would pause net loop and cause timeout. Now game continues to simulate in background, and inputs are disabled while pause menu open in online. Dependent on fishfolk/bones#411, CI will fail until updated. Fixes #1001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SessionRunner trait API for disabling local input. The use case for this is that in Jumpy when pausing the game in networked play, we do not want to set net game session inactive, as network loop will stop running and we will timeout. Instead can allow it to continue simulating and disable local input instead as a "pause".