feat(networking): Add 'DisconnectedPlayers' resource to net session runner#409
Merged
MaxCWhitehead merged 1 commit intofishfolk:mainfrom Jun 8, 2024
Merged
Conversation
e63939a to
4632e0c
Compare
github-merge-queue bot
pushed a commit
to fishfolk/jumpy
that referenced
this pull request
Jun 8, 2024
During a game, if all other players have been disconnected, UI pop-up will notify player providing button to return to main menu. If one player but not all have disconnected, going to have game keep going / figure out how to handle this separately. Relates to #994, will not fix anything, but if hung due to disconnect, will inform player at least. Depends on fishfolk/bones#409, CI will fail until merged + update bones version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each frame
DisconnectedPlayersresource is updated in net session, can be used by game to determine which players may not be connected.If rollback before a disconnect - player is still listed in resource, because dc'd players are persisted on runner directly + copied to resource.