feat(networking): Allow game to specify net max prediction + local input delay instead of hard coding.#354
Merged
zicklag merged 1 commit intofishfolk:mainfrom Mar 23, 2024
Conversation
delay instead of hard coding. Change defaults from 10 and 1 to 7 and 2.
MaxCWhitehead
added a commit
to fishfolk/jumpy
that referenced
this pull request
Mar 24, 2024
…from metadata (#935) I opened a PR in bones to expose these settings for networking, instead of hard coding in engine. (fishfolk/bones#354) The defaults of these values were also changed in bones such that things are feeling much better in network play with ping around 100ms-150ms. Now we may tune in metadata, though settings only take effect if new network match is created. This will not pass CI until bones PR is merged + bones version updated.
MaxCWhitehead
added a commit
to MaxCWhitehead/jumpy
that referenced
this pull request
Mar 24, 2024
…from metadata (fishfolk#935) I opened a PR in bones to expose these settings for networking, instead of hard coding in engine. (fishfolk/bones#354) The defaults of these values were also changed in bones such that things are feeling much better in network play with ping around 100ms-150ms. Now we may tune in metadata, though settings only take effect if new network match is created. This will not pass CI until bones PR is merged + bones version updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game may now configure their own GGRS settings for max prediction + input delay.
Change defaults from 10 and 1 to 7 and 2. This seems to help a ton with ping up to 150ms, in which it was very poppy before. Further tuning will be done in jumpy's config, but this seems like maybe a better default for now.
Slight more delay on game, but I think 2 frames at 60fps is quite acceptable, and this helps higher latency matches a lot.