feat(frame-time-diagnostisc): Re-add frame time diagnostics window to bones#346
Merged
zicklag merged 2 commits intofishfolk:mainfrom Mar 12, 2024
Merged
Conversation
zicklag
approved these changes
Mar 6, 2024
MaxCWhitehead
added a commit
to fishfolk/jumpy
that referenced
this pull request
Mar 13, 2024
companion PR for: fishfolk/bones#346 frame time window re-added to bones, this enables viewing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If session plugin is installed, egui state may be used to display window.
Decided to continue using Bevy frame diagnostics plugin instead of measuring in bones, as wanted to make sure data is accurate / representative of full frame and not just the execution of bevy bones app.