feat(ai) Live Service Going Away notifications#9461
Conversation
🦋 Changeset detectedLatest commit: 55cf871 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @DellaBitta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates 'Going Away' notifications into the AI SDK's Live Service. This enhancement provides a mechanism for the service to proactively alert clients about impending session terminations, improving user experience by allowing applications to gracefully handle session closures. The changes involve updating the API contract, implementing the new notification type within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Vertex AI Mock Responses Check
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for GOING_AWAY_NOTICE notifications in the Live Service, which is a useful addition for handling session lifecycle events. The changes are well-implemented across the API definitions, implementation, and tests. My main feedback is to add the @beta tag to the new LiveServerGoingAwayNotice interface for consistency with the rest of the Live API, which is currently in beta. This will ensure correct API documentation generation.
.changeset/long-monkeys-prove.md
Outdated
| 'firebase': minor | ||
| --- | ||
|
|
||
| AI Logic: Extend the `LiveSession.recieve()` return types to include a `LiveServiceGoingAwayNotice` |
| * @param duration - The duration string to parse. | ||
| * @returns The duration in seconds. | ||
| */ | ||
| function parseDuration(duration: string | undefined): number { |
There was a problem hiding this comment.
I knew I remembered this from somewhere. Should we make this a shared util? https://github.com/firebase/firebase-js-sdk/blob/main/packages/app-check/src/client.ts#L92 Can do it in a future PR as we should discuss what the util returns if it fails to parse.
### Discussion Support the handling of Going Away notifications in the Live Service. The service may send this event when the session is coming to a close due to timeout or nearing a token limit. ### Testing Unit tests added. Manual testing. ### API Changes See internal [API proposal](https://goto.google.com/fal-firebase-api-live-api-goaway-message).
Discussion
Support the handling of Going Away notifications in the Live Service. The service may send this event when the session is coming to a close due to timeout or nearing a token limit.
Testing
Unit tests added.
Manual testing.
API Changes
See internal API proposal.