fix(auth): export MISSING_PASSWORD in AuthErrorCodes#9297
fix(auth): export MISSING_PASSWORD in AuthErrorCodes#9297dlarocque merged 6 commits intofirebase:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 174bd83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
When we make additions to public APIs, we have to update our reference documentation here on this website: https://firebase.google.com/docs/reference. The documentation hosted on that website is generated from the code in our SDK, and stored in the Since you made a public API addition, you need to generate the documentation for this new API. You can do this by running the |
|
Thanks for the review! |
|
Thanks for the reminder! |
|
Please ignore the CI errors. They're expected to fail on forks. One last thing though, can you run |
|
Added the generated auth.api.md via yarn build. |
|
Hi @dlarocque 👋 just checking in — The PR looks ready from my side, but I see the workflows are awaiting maintainer approval. |
|
Thanks for the contribution @Navya-arugonda! ❤️ |
* docs: Fix docgen script to clean out package temp folders first (#9250) * Version Packages (#9258) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Expose setUserProperties from internal analytics instance (#9263) * feat(ai): add support for URL context (#9254) * docs(ai): tag code execution with "beta" tag (public preview) (#9274) * fix(ai): Handle empty parts when streaming (#9262) * feat(ai): Add method to send function responses in a live session (#9272) * Update ai model name used for e2e tests (#9282) * docs(ai): promote gemini developer api and imagen to GA (#9255) * Version Packages (#9300) release v12.4.0 For JS SDK release v12.4.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(auth): export MISSING_PASSWORD in AuthErrorCodes (#9297) * update dependency --------- Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com> Co-authored-by: Christina Holland <chholland@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel La Rocque <dlarocque@google.com> Co-authored-by: Navya Sree Arugonda <67328292+Navya-arugonda@users.noreply.github.com>
Summary
Export
MISSING_PASSWORD: 'auth/missing-password'viaAuthErrorCodesin @firebase/auth.Why
The SDK can throw
auth/missing-password, but it wasn’t exposed viaAuthErrorCodes, forcing developers to hardcode the string.Tests
Adds a Node unit test asserting:
AuthErrorCodes.MISSING_PASSWORD === 'auth/missing-password'.Fixes
Fixes #9270
CLA
I have signed the Google Contributor License Agreement.