Conversation
|
DellaBitta
left a comment
There was a problem hiding this comment.
Assuming tests work, of course!
Size Report 1Affected ProductsNo changes between base commit (1e8edb7) and merge commit (af73a4c).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (1e8edb7) and merge commit (af73a4c).Test Logs |
Unfortunately it apparently is that. |
|
Problem never seems to have been fixed: karma-runner/karma-firefox-launcher#245 Possible solution: microsoft/playwright#20692 |
|
This is probably the problem? https://www.reddit.com/r/Ubuntu/comments/tolwrf/wtf_ubuntu_snaponly_enforced_for_firefox/ Ubuntu 22.04 has a "snap" version of Firefox built in, which doesn't seem to work well. As part of the workflow, we install Firefox fresh with |
We locked the ubuntu image for Firefox tests 2 years ago: #6833 because the new image was having issues. Hopefully that's been fixed by now, trying ubuntu-latest.
Conclusion: Firefox installed with apt-get seems to cause issues on Ubuntu 22.04, perhaps because of some conflict with Ubuntu 22.04's own pre-installed Snap version of Firefox. This can be solved either by removing the Firefox install altogether or by installing with puppeteer instead, which seems to not cause a conflict. Although removing the install and relying on the image's pre-installed Firefox works fine, and Github seems to update their Ubuntu regularly so it always has the latest version of Firefox, I prefer to use puppeteer for explicit control over the version. Maybe we want to lock it to some specific version or test with a specific version in the future, and this sets us up to easily do that.