fix: reset SNAP* env variables when launching Firefox#20692
Merged
aslushnikov merged 3 commits intomicrosoft:mainfrom Feb 7, 2023
Merged
fix: reset SNAP* env variables when launching Firefox#20692aslushnikov merged 3 commits intomicrosoft:mainfrom
aslushnikov merged 3 commits intomicrosoft:mainfrom
Conversation
Our builds never come from Snap, so Playwright's Firefox should never consider that it's been installed via SNAP. Fixes microsoft#20555
yury-s
approved these changes
Feb 6, 2023
| // Always remove SNAP_NAMe and SNAP_INSTANCE_NAME env variables since they | ||
| // confuse Firefox: in our case, builds never come from SNAP. | ||
| // See https://github.com/microsoft/playwright/issues/20555 | ||
| return {...env, SNAP_NAME: undefined, SNAP_INSTANCE_NAME: undefined }; |
Member
There was a problem hiding this comment.
nit: can we have a test for this?
dgozman
approved these changes
Feb 6, 2023
mxschmitt
reviewed
Feb 6, 2023
Co-authored-by: Max Schmitt <max@schmitt.mx> Signed-off-by: Andrey Lushnikov <aslushnikov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our builds never come from Snap, so Playwright's Firefox should
never consider that it's been installed via SNAP.
Fixes #20555