Fix for 8474 - Prevent a possible condition of slow snapshots, caused by a rapid series of document update(s) followed by a delete.#8595
Merged
MarkDuckworth merged 7 commits intomainfrom Oct 30, 2024
Conversation
🦋 Changeset detectedLatest commit: 91fa315 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Pls add a description of the fix, in addition to the issue number |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
dconeybe
approved these changes
Oct 25, 2024
DellaBitta
reviewed
Oct 25, 2024
Contributor
DellaBitta
left a comment
There was a problem hiding this comment.
Please add a changeset, and could you rename the PR to be descriptive. Feel free to keep the "Fix for 8474" but also describe what has changed.
dconeybe
approved these changes
Oct 25, 2024
DellaBitta
approved these changes
Oct 28, 2024
Merged
ashish-kothari
added a commit
that referenced
this pull request
Nov 24, 2024
Squashed commit of the following: commit ffbf5a6 Author: Google Open Source Bot <firebase-oss-bot@google.com> Date: Thu Nov 14 07:04:30 2024 -0800 Version Packages (#8635) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2c27206 Merge: a75082f e3e2078 Author: Google Open Source Bot <firebase-oss-bot@google.com> Date: Tue Nov 12 07:48:12 2024 -0800 Merge main into release commit e3e2078 Author: Daniel La Rocque <dlarocque@google.com> Date: Wed Nov 6 09:57:57 2024 -0500 Consolidate CI test output into a single string (#8489) * Consolidate CI test output into a single string Having CI test process stdout and stderr in a single string makes it easier to read when looking through failures, since you can see the test output alongside the error messages. Without this, any stderr output written during a test will be captured seperately from the test output, so when we then log it after a test failure, we can't tell which test logged which errors. * Prefix stdout and stderr output commit 274e9a5 Author: Daniel La Rocque <dlarocque@google.com> Date: Tue Nov 5 17:25:54 2024 -0500 Remove unused `convertPropertiesForEnclosingClass" (#8618) commit caf3090 Author: Daniel La Rocque <dlarocque@google.com> Date: Wed Oct 30 15:12:32 2024 -0400 Upgrade ts-node to 10.19.2 (#8531) commit 0f5714b Author: Mark Duckworth <1124037+MarkDuckworth@users.noreply.github.com> Date: Wed Oct 30 10:05:19 2024 -0600 Fix for 8474 - Prevent a possible condition of slow snapshots, caused by a rapid series of document update(s) followed by a delete. (#8595) commit d4cb3f8 Author: Daniel La Rocque <dlarocque@google.com> Date: Mon Oct 28 14:32:13 2024 -0400 Upgrade workflows Node version from `20.x` to `22.10.0` (#8601) Node 22 enters LTS on October 29th, 2024, so we should upgrade CI to run on Node 22. commit b807119 Author: Daniel La Rocque <dlarocque@google.com> Date: Fri Oct 25 15:16:08 2024 -0400 Remove modifiers from compat overloads (#8604) * Remove modifiers from compat overloads * format * Add changeset commit 612335d Author: Daniel La Rocque <dlarocque@google.com> Date: Fri Oct 25 14:31:32 2024 -0400 Upgrade webpack dependencies in e2e tests (#8605)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8474.
Summary:
A rapid sequence of events for a single document, within the window of a single global snapshot, can result in delayed limbo resolution for that document.
The events sequence leading to the delay are:
When these two events occur within the window of a single global snapshot, the limbo resolution associated with the delete event, is delayed until the next global snapshot.