Firestore: Re-write sample code in FirestoreDataConverter docs#7673
Merged
Firestore: Re-write sample code in FirestoreDataConverter docs#7673
Conversation
🦋 Changeset detectedLatest commit: 14c249b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
…neybe/FirestoreDataConverterSampleCodeRewrite
dconeybe
commented
Oct 5, 2023
Contributor
Author
dconeybe
left a comment
There was a problem hiding this comment.
Thanks for the improvements! I've just left a few optional comments for you to consider. Otherwise, LGTM.
markarndt
approved these changes
Oct 6, 2023
…terSampleCodeRewrite
Contributor
Changeset File Check
|
MarkDuckworth
approved these changes
Dec 11, 2023
Contributor
MarkDuckworth
left a comment
There was a problem hiding this comment.
@dconeybe I addressed your feedback to my changes. I believe this PR is good to go.
dconeybe
added a commit
to googleapis/nodejs-firestore
that referenced
this pull request
Dec 12, 2023
The old sample had blatant syntax errors and was lacking in its demonstration of the power of type converters. These changes are ported from firebase/firebase-js-sdk#7673
dconeybe
added a commit
to googleapis/nodejs-firestore
that referenced
this pull request
Dec 12, 2023
The old sample had blatant syntax errors and was lacking in its demonstration of the power of type converters. These changes are ported from firebase/firebase-js-sdk#7673
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-write the sample code for
FirestoreDataConverter. The old sample had blatant syntax errors and was lacking in its demonstration of the power of type converters.This improvements was ported to the nodejs-firestore repository in googleapis/nodejs-firestore#1958.
Fixes: #7671