fix race condition checkin is deleted before writing during app start #2860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Apr 18, 2019
Member
|
Marking for M48 milestone. |
maksymmalyhin
approved these changes
Apr 18, 2019
paulb777
pushed a commit
that referenced
this pull request
Apr 23, 2019
paulb777
added a commit
that referenced
this pull request
Apr 23, 2019
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
paulb777
added a commit
that referenced
this pull request
May 7, 2019
* Update versions for Release 6.0.0 * Update FirebaseSDKs.textproto with new fields. (#2818) (#2834) * Update FirebaseSDKs.textproto with new fields. * Update message about strip_32bits flag. * GULAppDelegateSwizzler - proxy APNS methods separately (#2835) (#2858) * Cherry-picks for M47 RC5 (#2882) * fix race condition checkin is deleted before writing during app start (#2860) * GoogleUtilities min ios version from 6 to 8 (#2876) * Put secret and oauth credentials into the private headers for now. (#2916) (#2919) * Add missing Messaging weak_framework dep (#2921) (#2930)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prevention fix for #2438 because we still couldn't reproduce. But users are facing race condition where checkin plist file is deleted after a new checkin is written to the file. So we move the plist deletion call to the first step of resetting checkin during app start. Because FIRInstanceID init call should be always before first checkin call got issued.
Also add two more logs which helps provide the timeline when checkin plist file is written or read.