Firestore: Downgrade grpc CocoaPods dependency to 1.44.0 (was 1.50.1)#11846
Merged
Firestore: Downgrade grpc CocoaPods dependency to 1.44.0 (was 1.50.1)#11846
Conversation
Leave the cmake and swift package manager dependencies at 1.50 since they do not experience this crash. This is a workaround for a Firestore crash on iOS 12 with grpc 1.50.0 and newer: #11509
Collaborator
Coverage Report 1Affected Products
Test Logs |
paulb777
approved these changes
Sep 25, 2023
This was referenced Sep 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrade grpc CocoaPods dependency to 1.44.0 (was 1.50.1) as a workaround for a Firestore crash on iOS 12 that happens with with grpc 1.50.0 and newer: #11509. Leave the cmake and swift package manager dependencies at 1.50 since they do not experience this crash.
A workaround for this crash is planned to be merged into grpc upstream (grpc/grpc#34416). Once released (and a few other unrelated grpc build issues with Firestore are fixed) the grpc dependency will be re-upgraded to a version that includes the workaround.
Note: This PR effectively reverts #10650.
Fixes #11509