Skip to content

Upgrade grpc to 150 and C++ to 14 For Cocoapods#10650

Merged
cherylEnkidu merged 6 commits intomasterfrom
wuandy/GRPC150Apple
Apr 25, 2023
Merged

Upgrade grpc to 150 and C++ to 14 For Cocoapods#10650
cherylEnkidu merged 6 commits intomasterfrom
wuandy/GRPC150Apple

Conversation

@wu-hui
Copy link
Copy Markdown
Contributor

@wu-hui wu-hui commented Jan 6, 2023

No description provided.

paulb777
paulb777 reviewed Jan 6, 2023
View reviewed changes
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jan 6, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.00% (6304c23) to 88.05% (02a863c) by +0.05%.

    FilenameBase (6304c23)Merge (02a863c)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.14%-0.69%
    leveldb_remote_document_cache.cc96.41%94.61%-1.80%
    ordered_code.cc94.39%93.90%-0.49%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VdseeyCqZO.html

@HannahShiSFB HannahShiSFB mentioned this pull request Jan 21, 2023
Merged
@HannahShiSFB
Copy link
Copy Markdown

HannahShiSFB commented Feb 10, 2023

We have released 1.50.1, can you try if it passes

@wu-hui wu-hui requested a review from cherylEnkidu April 3, 2023 17:39
@wu-hui wu-hui force-pushed the wuandy/GRPC150Apple branch from 811e69e to 26e56c2 Compare April 3, 2023 18:17
@wu-hui
Copy link
Copy Markdown
Contributor Author

wu-hui commented Apr 3, 2023

We have released 1.50.1, can you try if it passes

Thanks, I am seeing build error however: https://github.com/firebase/firebase-ios-sdk/actions/runs/4599998333/jobs/8126084582?pr=10650

@sampajano FYI

@sampajano
Copy link
Copy Markdown

sampajano commented Apr 3, 2023

@HannahShiSFB Hi Hannah could you help take a look at the above error and if they ring a bell? Thanks!

@dconeybe dconeybe mentioned this pull request Apr 6, 2023
Closed
@ncooke3 ncooke3 self-requested a review April 21, 2023 17:14
@HannahShiSFB HannahShiSFB mentioned this pull request Apr 24, 2023
Merged
@cherylEnkidu cherylEnkidu merged commit 483ccd3 into master Apr 25, 2023
@cherylEnkidu cherylEnkidu deleted the wuandy/GRPC150Apple branch April 25, 2023 17:22
This was referenced Apr 27, 2023
Closed
Merged
Merged
Merged
@ncooke3 ncooke3 changed the title Upgrade grpc to 150 and C++ to 14 For Cocoapods and SPM Upgrade grpc to 150 and C++ to 14 For Cocoapods May 3, 2023
@ncooke3
Copy link
Copy Markdown
Member

ncooke3 commented May 3, 2023

@wu-hui, FYI ICYMI, #11208 updated this for SPM

@wu-hui
Copy link
Copy Markdown
Contributor Author

wu-hui commented May 3, 2023

@wu-hui, FYI ICYMI, #11208 updated this for SPM

Thank you!

@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 left review comments

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

Assignees

@cherylEnkidu cherylEnkidu

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wu-hui @google-oss-bot @HannahShiSFB @sampajano @ncooke3 @paulb777 @cherylEnkidu