Skip to content

[Release] Update gRPC and Abseil deps#11208

Merged
paulb777 merged 4 commits intomasterfrom
nc/bump-abseil-and-grpc
Apr 28, 2023
Merged

[Release] Update gRPC and Abseil deps#11208
paulb777 merged 4 commits intomasterfrom
nc/bump-abseil-and-grpc

Conversation

@ncooke3
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 commented Apr 28, 2023 •
edited
Loading

Context

Edit: I pinned the QS to master instead of nc/bump-abseil-and-grpc. Using nc/bump-abseil-and-grpc, the QS fails.

#no-changelog

@ncooke3 ncooke3 requested review from paulb777 and wu-hui April 28, 2023 18:08
@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 28, 2023

@paulb777, oh I didn't think of this... the spm / ClientApp workflow fails because it is using these new dependencies with the old Firestore binary. So bumping these deps means also updating the Firestore binary in the Package.swift so SPM on master doesn't have a broken Firestore target.

@paulb777
Copy link
Copy Markdown
Member

paulb777 commented Apr 28, 2023

Hmm, that shouldn't be the case if those are really minor version updates?

@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 28, 2023

Hmm, that shouldn't be the case if those are really minor version updates?

Here's what I see.
Screenshot 2023-04-28 at 2 28 53 PM

@paulb777
Copy link
Copy Markdown
Member

paulb777 commented Apr 28, 2023 •
edited
Loading

Where are the undefined symbol references from? They should show up if you click the top right hamburger

@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 28, 2023

Firestore QS builds and runs with the latest commit.

@paulb777
Copy link
Copy Markdown
Member

paulb777 commented Apr 28, 2023

Merging so it's included started in tonight's nightlies.

@paulb777 paulb777 merged commit 3420fcb into master Apr 28, 2023
@paulb777 paulb777 deleted the nc/bump-abseil-and-grpc branch April 28, 2023 20:44
@ncooke3 ncooke3 mentioned this pull request May 3, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ncooke3 @paulb777