Skip to content

[Firestore] Change Firestore's release distro from source to binary for SPM#11066

Merged
ncooke3 merged 18 commits intomasterfrom
nc/binary-firestore-1080
Apr 5, 2023
Merged

[Firestore] Change Firestore's release distro from source to binary for SPM#11066
ncooke3 merged 18 commits intomasterfrom
nc/binary-firestore-1080

Conversation

@ncooke3
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 commented Apr 3, 2023 •
edited
Loading

Context

Code Freeze Day + 1 Steps

Before Merging

  • Wait for rc0 zip to be created
  • Update and publish Abseil binary release using artifact from zip
    • abseil.xcframework
  • Update and publish GRPC binary release using artifacts from zip
    • gRPC-C++.xcframework
    • gRPC-Core.xcframework
    • BoringSSL-GRPC.xcframework
  • Update and publish Firestore binary release using artifact from zip
    • FirebaseFirestore.xcframework
  • Update this branch with new Firestore checksum
  • Confirm this branch resolves
  • Confirm Firestore quickstart builds and functions
  • Update CHANGELOG entry's version
  • Update PR title and description
  • Merge this PR when:
    • Approvals
    • Green CI

After Merging

  • Move release (CocoaPods) tag to include this new commit

Fixes #6564

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Apr 3, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.27% (98e218b) to 88.24% (1965ef8) by -0.02%.

    FilenameBase (98e218b)Merge (1965ef8)Diff
    leveldb_key.cc98.33%98.14%-0.20%
    leveldb_remote_document_cache.cc96.41%94.61%-1.80%
    task.cc94.78%93.91%-0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8ay1ctY2lC.html

@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 4, 2023

Green CI: https://github.com/firebase/firebase-ios-sdk/pull/11066/checks?sha=d8bdd5a86a8f141397186704859175bf57b970da

Now, will remove the dummy file that was used to trigger the Firestore CI.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Apr 4, 2023

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (a150f0b)Merge (66513dd)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NzSNwSQyEx.html

@ncooke3 ncooke3 added this to the 10.8.0 - M130 milestone Apr 4, 2023
@ncooke3 ncooke3 force-pushed the nc/binary-firestore-1080 branch from ff9627d to e39ae6f Compare April 5, 2023 15:17
@ncooke3 ncooke3 changed the title [Firestore][DNM] Test binary Firestore distro on CI [Firestore] Change Firestore's release distro from source to binary for SPM Apr 5, 2023
@ncooke3 ncooke3 marked this pull request as ready for review April 5, 2023 15:27
ncooke3
ncooke3 commented Apr 5, 2023
View reviewed changes
@andrewheard
Copy link
Copy Markdown
Contributor

andrewheard commented Apr 5, 2023

Any luck with "Confirm Firestore quickstart builds and functions" ? Otherwise LGTM!

@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 5, 2023 •
edited
Loading

Any luck with "Confirm Firestore quickstart builds and functions" ? Otherwise LGTM!

I'm in the process of that right now! Will update in a few mins.

edit: @andrewheard, QS builds and functions.

paulb777
paulb777 approved these changes Apr 5, 2023
View reviewed changes
@ncooke3 ncooke3 merged commit 9d986c8 into master Apr 5, 2023
@ncooke3 ncooke3 deleted the nc/binary-firestore-1080 branch April 5, 2023 17:00
@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 5, 2023

Merging to re-tag for release while master is still clean. I can address any follow-up questions/concerns in a follow-up PR.

@ncooke3 ncooke3 mentioned this pull request Apr 13, 2023
Merged
@firebase firebase locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard andrewheard approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

Assignees

No one assigned

Labels

api: firestore

Projects

None yet

Milestone

10.8.0 - M130

Development

Successfully merging this pull request may close these issues.

Support for Swift Package Manager binaryTarget by providing xcframework in a release

4 participants

@ncooke3 @google-oss-bot @andrewheard @paulb777