Skip to content

[Release] Update Package.swift for 1.44.0 release#2

Merged
ncooke3 merged 1 commit intomainfrom
nc/version
Apr 5, 2023
Merged

[Release] Update Package.swift for 1.44.0 release#2
ncooke3 merged 1 commit intomainfrom
nc/version

Conversation

@ncooke3
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 commented Apr 5, 2023

Context

  • After merging, I will publish 1.44.0 tag

#no-changelog

@ncooke3 ncooke3 requested a review from paulb777 April 5, 2023 15:00
// TODO(ncooke3): Figure out versioning stratgey for binary Abseil releases.
// BEFORE: "0.20220623.0"..<"0.20220624.0"
.exact("10.8.0-rc.1")
"1.2021110200.0" ..< "1.2021110300.0"
Copy link
Copy Markdown
Member Author

@ncooke3 ncooke3 Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777, could you take a close look at this when reviewing. I tried to copy what was done here: https://github.com/grpc/grpc-ios/blob/main/Package.swift#L23

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We're allowing both patch updates for the abseil library and for the abseil SPM infra.

// TODO(ncooke3): Figure out versioning stratgey for binary Abseil releases.
// BEFORE: "0.20220623.0"..<"0.20220624.0"
.exact("10.8.0-rc.1")
"1.2021110200.0" ..< "1.2021110300.0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We're allowing both patch updates for the abseil library and for the abseil SPM infra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants