Skip to content

Closes #153. Add additional FCM options for Android Notification#203

Merged
lahirumaramba merged 2 commits into
firebase:fcm-android-notif-paramfrom
levimatheri:android-notification-api
Nov 11, 2021
Merged

Closes #153. Add additional FCM options for Android Notification#203
lahirumaramba merged 2 commits into
firebase:fcm-android-notif-paramfrom
levimatheri:android-notification-api

Conversation

@levimatheri

@levimatheri levimatheri commented Jun 28, 2020 •
edited by lahirumaramba
Loading

Copy link
Copy Markdown
Contributor

I couldn't get xUnit to compare LightSettingsColor so I assert the properties separately.
Let me know if there's changes I should make.

Thanks!

Related to: #153

@levimatheri levimatheri mentioned this pull request Nov 10, 2021
Closed
@lahirumaramba lahirumaramba changed the base branch from master to fcm-android-notif-param November 11, 2021 19:04
@lahirumaramba

lahirumaramba commented Nov 11, 2021

Copy link
Copy Markdown
Member

Thank you @levimatheri for the contribution!
There are a few minor changes we have to make in order to match the public API to the internally approved one (for example,PriorityType should be renamed to Priority). These are minor changes and I can take over from here. As the next step I am merging this PR to a feature branch fcm-android-notif-param. I will add integration tests and other minor changes to the API there before merging to the main branch.

@lahirumaramba lahirumaramba merged commit 0547948 into firebase:fcm-android-notif-param Nov 11, 2021
@lahirumaramba

lahirumaramba commented Nov 11, 2021

Copy link
Copy Markdown
Member

@levimatheri I realized that you decided to use PriorityType for the enum to avoid naming conflicts. Thank you. We might have to revise the internal proposal to reflect this change before releasing the API. I will update the progress here.

@bigpjo

bigpjo commented Jan 19, 2022

Copy link
Copy Markdown

Thank you @levimatheri . @lahirumaramba do you know when this pull request is likely to be merged, this is a fantastic package and it will be great for us to use the localization options available when this is merged

@lahirumaramba lahirumaramba mentioned this pull request Mar 4, 2022
Merged
@lahirumaramba

lahirumaramba commented Mar 4, 2022

Copy link
Copy Markdown
Member

Thank you for your patience! The initial changes required updates to the internally proposed public API. It also required a few changes to the light settings color conversion. I have started #317 to merge all the changes (proposed by @levimatheri Thank you!) to the main branch.

lahirumaramba added a commit that referenced this pull request Mar 15, 2022
@lahirumaramba @levimatheri
feat (fcm): Add additional Android Notification Parameters (#317)
2f7c9a9 
* Closes #153. Add additional FCM options for Android Notification (#203)

* Add additional FCM Android notification options

* Add additional FCM Android notification options

* Update API to match the approved changes

* Trigger CI

* Move enum types out of the nested class

* Fix docs

Co-authored-by: levimatheri <levimatheri@gmail.com>
@lahirumaramba lahirumaramba mentioned this pull request Mar 23, 2022
Merged
lahirumaramba added a commit that referenced this pull request Mar 24, 2022
@lahirumaramba
[chore] Release 2.3.0 (#319)
0f5b388 
Includes #317 and #203
@lahirumaramba lahirumaramba mentioned this pull request Mar 24, 2022
Merged
@lahirumaramba

lahirumaramba commented Mar 24, 2022

Copy link
Copy Markdown
Member

This feature is now available in v2.3.0. Thank you for your contribution!

@lahirumaramba lahirumaramba mentioned this pull request Mar 30, 2022
Open
This was referenced Feb 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

Assignees

@lahirumaramba lahirumaramba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@levimatheri @lahirumaramba @bigpjo