Make allValues argument optional on type FieldValidator#394
Merged
erikras merged 3 commits intofinal-form:mainfrom Apr 1, 2022
Merged
Make allValues argument optional on type FieldValidator#394erikras merged 3 commits intofinal-form:mainfrom
allValues argument optional on type FieldValidator#394erikras merged 3 commits intofinal-form:mainfrom
Conversation
Member
|
Published in |
CarsonF
added a commit
to SeedCompany/cord-field
that referenced
this pull request
Aug 11, 2022
2nd arg was made optional for unknown reasons. Ignore this as FF always passes this value, so it's safe to use without checking for null. final-form/final-form#394
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use the type in my code and stumbled upon this.
Also, I think it's a good idea to export these types (as all the other ones).