Skip to content

fix(oidc): add missing idp attribute#2600

Merged
monkeyiq merged 1 commit intofilesender:developmentfrom
dkfz-itcf:development
Mar 5, 2026
Merged

fix(oidc): add missing idp attribute#2600
monkeyiq merged 1 commit intofilesender:developmentfrom
dkfz-itcf:development

Conversation

@flowdnb
Copy link
Copy Markdown
Contributor

@flowdnb flowdnb commented Mar 5, 2026

Fix missing 'idp' attribute in OIDC authentication

#2569

@monkeyiq monkeyiq merged commit 751576b into filesender:development Mar 5, 2026
5 checks passed
@monkeyiq
Copy link
Copy Markdown
Contributor

monkeyiq commented Mar 5, 2026

This should also be merged into development3 when I do the periodic merge between d and d3.

@victoritis
Copy link
Copy Markdown

As i see, this was merged to development and not development3, where i need it. Thanks

@flowdnb
Copy link
Copy Markdown
Contributor Author

flowdnb commented Mar 14, 2026

This PR covers v2, but per PR #2616 and PR #2335's precedent, v3 still needs OIDC-specific ensureLocalIdPMetadata. PR #2335 demonstrated that explicit IdP metadata handling is required for complete SSO provider coverage - this pattern hasn't been applied to OIDC in v3 yet. Suggest implementing #2335 (or at least the changes to classes/auth/AuthSPOidc.class.php) to align OIDC with the established SAML/Shibboleth metadata persistence approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants