add basic ensureLocalIdPMetadata for Shibboleth#2335
Merged
monkeyiq merged 1 commit intofilesender:development3from Jul 19, 2025
Merged
add basic ensureLocalIdPMetadata for Shibboleth#2335monkeyiq merged 1 commit intofilesender:development3from
monkeyiq merged 1 commit intofilesender:development3from
Conversation
For this to be fully functional in the new stats update I need to play around more with some IdPs for Shibboleth and check that per IdP data is properly presented. Many of the fields in the idps table for Shibboleth will be left as null for now. For SSP the code was reading the remote idp listing from the library. For the code to match in Shibboleth it should also be looking at the metadata for the remote IdPs that the Shibboleth SP knows about and adding that information into the local idps table in FileSender.
Contributor
Author
|
This was raised in #2334 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this to be fully functional in the new stats update I need to play around more with some IdPs for Shibboleth and check that per IdP data is properly presented. Many of the fields in the idps table for Shibboleth will be left as null for now.
For SSP the code was reading the remote idp listing from the library. For the code to match in Shibboleth it should also be looking at the metadata for the remote IdPs that the Shibboleth SP knows about and adding that information into the local idps table in FileSender.