fix: clear selection by clicking on empty area #5663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does it also work if you click somewhere else within page that is not the listing |
…ound-does-not-deselect-files-(Mobile/Desktop)
…ound-does-not-deselect-files-(Mobile/Desktop)
Contributor
Author
No, it only happens when you click on an empty area of the file and directory listing div, similar to how it works in Windows File Explorer. I think extending it to the rest of the interface could be confusing. |
Member
|
You have a point, I just tested it on macOS too and it behaves the same as on Windows |
hacdias
approved these changes
Jan 10, 2026
|
Thanks, this was one of the pain points for me, and I had to refresh the page in the browser to clear the selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you click in the file and directory listing area, if you clicked in an empty area (i.e., you did not click on a file or directory card), the selection is cleared (if one or more files or directories were selected).
Additional Information
Closes #5660
Checklist
Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
masterbranch.