Skip to content

fix: hide "change password form" in noauth setting #5652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hacdias merged 2 commits into from
Jan 10, 2026
Merged

fix: hide "change password form" in noauth setting #5652

hacdias merged 2 commits into from
Jan 10, 2026

Conversation

@ArielLeyva
Copy link
Contributor

@ArielLeyva ArielLeyva commented Dec 31, 2025 •
edited
Loading

Description

The form that allows you to change your password in your profile is hidden if the authentication setting is set to "noauth"

Additional Information

Closes #5650

Checklist

Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • I am aware the project is currently in maintenance-only mode. See README
  • I am aware that translations MUST be made through Transifex and that this PR is NOT a translation update
  • I am making a PR against the master branch.
  • I am sure File Browser can be successfully built. See builds and development.

@ArielLeyva ArielLeyva requested a review from a team as a code owner December 31, 2025 05:19
@ArielLeyva ArielLeyva closed this Jan 3, 2026
@ArielLeyva ArielLeyva force-pushed the #5650/fix-Users-should-not-see-'change-password'-setting-with-noauth-auth-method branch from d0f79c4 to 94ec786 Compare January 3, 2026 14:11
@ArielLeyva ArielLeyva reopened this Jan 3, 2026
@ArielLeyva ArielLeyva closed this Jan 7, 2026
@ArielLeyva
Copy link
Contributor Author

ArielLeyva commented Jan 7, 2026

I closed this PR to avoid the same problem described here: #5666. I've opened a new PR (#5667) to fix the problem, and if the change is accepted, I'll reopen this PR and adjust the code accordingly.

@ArielLeyva ArielLeyva reopened this Jan 8, 2026
@hacdias hacdias merged commit 219582c into filebrowser:master Jan 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hacdias hacdias hacdias approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Users should not see 'change password' setting with noauth auth method

2 participants

@ArielLeyva @hacdias