fix: display friendly error message for password validation on signup #5563
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8637a03 to
a7090de
Compare
The signup function was not reading the response body before throwing an error, causing users to see only "400 Bad Request" instead of the actual validation message. Changes: - Read response body in signup() to capture error details - Add 400 status handling in Login.vue to display errors in form - Parse password length errors to show user-friendly message - Add translation string for password minimum length error Fixes filebrowser#5499 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
a7090de to
7bae594
Compare
hacdias
approved these changes
Nov 19, 2025
|
Hi thanks for implementing the fix! Just to check this fix has not been released correct? |
Contributor
Author
Correct. The code has been approved and merged, but it hasn't been added to a release yet. Probably very soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
signup()function inauth.tswas not reading the response body before throwing a StatusError, causing password validation errors to display as "404 error not found" instead of the actual error messageChanges
signup()to match the pattern used inlogin()passwordTooShorttranslation stringAlternative Approach
If you prefer a simpler implementation, the fix to
auth.tsalone (reading the response body) would display the backend's error message directly: "400 Bad Request (password is too short, minimum length is 12)". The additional changes in this PR parse the error to show a cleaner message without the HTTP status prefix.Screenshots
Current behavior (bug)
With passthrough fix only
With this PR (friendly message)
Checklist
Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
masterbranch.