fix: show login when session token expires #5439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ramiresviana
left a comment
There was a problem hiding this comment.
Since the logout is happening without user interaction, adding a message to inform the user they’ve been logged out would make the behavior clearer. Also, please ensure the code passes linter checks by running pnpm run lint to avoid errors when this PR is merged.
Contributor
Author
Perfect, I made that change and I had no problems with |
Contributor
ramiresviana
left a comment
There was a problem hiding this comment.
You have to fix the lint warnings
frontend > pnpm run lint
> filebrowser-frontend@3.0.0 lint /home/filebrowser/frontend
> eslint src/
/home/filebrowser/frontend/src/types/user.d.ts
66:40 warning Insert `⏎` prettier/prettier
/home/filebrowser/frontend/src/utils/auth.ts
27:14 warning Replace `'inactivity'` with `"inactivity"` prettier/prettier
116:7 warning Insert `·` prettier/prettier
117:20 warning Delete `·` prettier/prettier
118:24 warning Delete `·` prettier/prettier
119:43 warning Insert `,` prettier/prettier
122:20 warning Delete `·` prettier/prettier
125:6 warning Delete `⏎····` prettier/prettier
/home/filebrowser/frontend/src/views/Login.vue
6:55 warning Replace `{{t(`login.logout_reasons.${reason}`)}}` with `⏎········{{·t(`login.logout_reasons.${reason}`)·}}⏎······` prettier/prettier
74:28 warning Replace `'logout-reason'` with `"logout-reason"` prettier/prettier
130:10 warning Insert `⏎` prettier/prettier
✖ 11 problems (0 errors, 11 warnings)
0 errors and 11 warnings potentially fixable with the `--fix` option.
…res' of https://github.com/ArielLeyva/filebrowser into fix/filebrowser#5212-show-login-when-session-token-expires
Contributor
Author
Code has been reformatted to comply with Prettier's guidelines. |
jake-dog
added a commit
to jake-dog/filebrowser
that referenced
this pull request
Nov 28, 2025
…th with custom logout is used
jake-dog
added a commit
to jake-dog/filebrowser
that referenced
this pull request
Nov 28, 2025
…th with custom logout is used
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5212
Description
Implements automatic frontend redirection to the login page when the authentication token expires, based on the backend’s token-expiration-time setting.
Checklist
Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
masterbranch.