Skip to content

fix: Dark mode input BG color#18778

Merged
danharrin merged 1 commit into4.xfrom
fix/dark-mode-input-bg-color
Dec 29, 2025
Merged

fix: Dark mode input BG color#18778
danharrin merged 1 commit into4.xfrom
fix/dark-mode-input-bg-color

Conversation

@danharrin
Copy link
Copy Markdown
Member

Fixes #18774.

@danharrin danharrin added this to the v4 milestone Dec 29, 2025
@danharrin danharrin added the bug Something isn't working label Dec 29, 2025
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Dec 29, 2025
@danharrin danharrin merged commit 45e97ce into 4.x Dec 29, 2025
49 checks passed
@danharrin danharrin deleted the fix/dark-mode-input-bg-color branch December 29, 2025 06:56
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Dec 29, 2025
@nessimabadi
Copy link
Copy Markdown
Contributor

nessimabadi commented Dec 31, 2025

HI @danharrin , i think that by doing this the background is fixed for date, datetime, and time inputs but for the rest of the inputs it removes the background in dark mode.

Here's a screenshoot
image

I'm using the forms library not in a panel, but in a custom app

@danharrin
Copy link
Copy Markdown
Member Author

Hi, the class that I removed should just be a 1% opacity white, so I do not understand why it would cause the issue in your screenshot. Are you able to reproduce it in a fresh repository?

@ziming
Copy link
Copy Markdown
Contributor

ziming commented Jan 1, 2026

i have the same issue

@danharrin
Copy link
Copy Markdown
Member Author

@ziming can I have an issue with a reproduction please?

@ziming
Copy link
Copy Markdown
Contributor

ziming commented Jan 1, 2026

Not sure about the ingredients needed to reproduce but it is happening on about 3-4 of my production sites. (I have 8 sites in total).

@danharrin
Copy link
Copy Markdown
Member Author

I'm sorry, I cannot reproduce locally so you need to help me. This PR was created to fix a different bug.

@ziming
Copy link
Copy Markdown
Contributor

ziming commented Jan 1, 2026

ok, if i figure out the right combination to reproduce it will let you know

@nessimabadi
Copy link
Copy Markdown
Contributor

nessimabadi commented Jan 5, 2026

I think i found the problem.
It occurs when using filament with the tailwind plugin "@tailwindcss/forms".

The plugin adds the following

image

Which sets the background to white on all inputs.

Before this pull request, all inputs had bg-white/[1%], but the PR removed it for only the date related inputs, so now the base layer of the typography plugin applies.

I could create a test repository if needed. Just adding the typography plugin and setting it up will cause the bug.

The problem occurs because Filament 3 applications required the typography plugin, and Filament 4 applications don't. During the upgrade if the user did not remove the plugin then this will happen.

@nessimabadi
Copy link
Copy Markdown
Contributor

@danharrin I created an issue to move the conversation there with a reproduction repository

#18874

jeremylongshore added a commit to jeremylongshore/filament that referenced this pull request Jan 5, 2026
When using the @tailwindcss/forms plugin, inputs get white backgrounds
by default. This caused dark mode inputs to appear white after PR filamentphp#18778
was merged.

Adding `bg-transparent` ensures the input inherits the background from
its container rather than using the tailwindcss/forms default.

Fixes filamentphp#18874

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
danharrin pushed a commit that referenced this pull request Jan 6, 2026
…rms (#18875)

When using the @tailwindcss/forms plugin, inputs get white backgrounds
by default. This caused dark mode inputs to appear white after PR #18778
was merged.

Adding `bg-transparent` ensures the input inherits the background from
its container rather than using the tailwindcss/forms default.

Fixes #18874

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: jeremylongshore <jeremylongshore@users.noreply.github.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Search icon has a different background than search input

3 participants