Skip to content

Use a compatible shasum for Mac#565

Merged
bors-ferrocene[bot] merged 1 commit intomainfrom
hoverbear/mac-llvm-cache-improvements
Apr 28, 2024
Merged

Use a compatible shasum for Mac#565
bors-ferrocene[bot] merged 1 commit intomainfrom
hoverbear/mac-llvm-cache-improvements

Conversation

@Hoverbear
Copy link
Member

@Hoverbear Hoverbear commented Apr 25, 2024 •
edited
Loading

sha256sum is not a valid binary on Mac, and appears to have been silently failing.

This is causing the llvm cache to not be used and adding ~20 mins to most Mac workflows.

$ sha256sum
Error: nu::shell::external_command

  × External command failed
   ╭─[entry #1:1:1]
 1 │ sha256sum
   · ────┬────
   ·     ╰── executable was not found
   ╰────
  help: No such file or directory (os error 2)

Exit status 1
$ shasum -a 256
asdasd^D
61b4c705859f4158d38090c1e38e8fdc4f3d29db007f012766276aa498835cf6  -

image
https://app.circleci.com/pipelines/github/ferrocene/ferrocene/3574/workflows/9f9f9a89-56a2-4074-bb18-ef5b7a29fa9f/jobs/17241

@Hoverbear Hoverbear self-assigned this Apr 25, 2024
@Hoverbear Hoverbear requested a review from emilyalbini April 25, 2024 19:47
@Hoverbear
Copy link
Member Author

Hoverbear commented Apr 26, 2024

bors try

tshepang
tshepang approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@tshepang tshepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Apr 28, 2024

Build succeeded:

  • full

@bors-ferrocene bors-ferrocene bot merged commit f26dc86 into main Apr 28, 2024
@bors-ferrocene bors-ferrocene bot deleted the hoverbear/mac-llvm-cache-improvements branch April 28, 2024 13:10
@github-actions github-actions bot added the backport:maybe PR candidate for backport label Apr 28, 2024
@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Apr 28, 2024

try

Merge conflict.

@Hoverbear Hoverbear mentioned this pull request May 7, 2024
Merged
bors-ferrocene bot added a commit that referenced this pull request May 7, 2024
@bors-ferrocene @Hoverbear
Merge #614
a423db6 
614: Make llvm-cache.sh log more useful and verbose information r=tshepang a=Hoverbear

We store our LLVM caches in a specific S3 bucket location. This PR ensures we log the location, it also ensures we log both when we start, and when we complete, both actions. (Previously we only logged starting storing the cache, and after restoring)

This fell mostly out of #565.

Co-authored-by: Ana Hobden <ana.hobden@ferrous-systems.com>
@github-actions github-actions bot removed the backport:maybe PR candidate for backport label Jul 2, 2024
@Hoverbear Hoverbear added the backport:manual PR requiring manual intervention to backport label Jul 2, 2024
Hoverbear added a commit that referenced this pull request Jul 2, 2024
@Hoverbear
Use a compatible shasum for Mac
6f0624f 
Ferrocene-backport-of: #565
@Hoverbear Hoverbear removed backport:manual PR requiring manual intervention to backport backport:1.79 labels Jul 2, 2024
tshepang pushed a commit that referenced this pull request Aug 19, 2025
@traviscross
Merge pull request #565 from JoelMarcey/add-background-appendix
502373a 
Add background section to FLS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tshepang tshepang tshepang approved these changes

@emilyalbini emilyalbini Awaiting requested review from emilyalbini

Assignees

@Hoverbear Hoverbear

Labels

merged-in:1.79

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hoverbear @tshepang @emilyalbini