Skip to content

Add MarkupContent and TextDocumentSyncOptions, remove unused uses#5

Merged
felixfbecker merged 2 commits intofelixfbecker:masterfrom
TysonAndre:add-markup-and-sync-options
Sep 16, 2018
Merged

Add MarkupContent and TextDocumentSyncOptions, remove unused uses#5
felixfbecker merged 2 commits intofelixfbecker:masterfrom
TysonAndre:add-markup-and-sync-options

Conversation

@TysonAndre
Copy link
Copy Markdown
Contributor

Fixes #4

Fix typos (detected by codespell, should have already been fixed in specification document)
remove unused use statements (detected by Phan)

…ements

Fixes felixfbecker#4

Fix typos, remove unused use statements
@TysonAndre TysonAndre force-pushed the add-markup-and-sync-options branch from 7ac55b0 to 234bbcd Compare September 16, 2018 21:06
Comment thread src/MarkupKind.php Outdated
{
/**
* Plain text is supported as a content format
*/
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfbecker felixfbecker merged commit f7f95a8 into felixfbecker:master Sep 16, 2018
@felixfbecker
Copy link
Copy Markdown
Owner

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

joehoyle added a commit to joehoyle/php-language-server-protocol that referenced this pull request Feb 22, 2021
It appears this was missed in felixfbecker#5, which sets the property to allow MarkupContent, but doesn't allow instantiating the object with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new classes from the specification

2 participants