Separated @fedify/fedify/runtime with @fedify/vocab-tools#458
Separated @fedify/fedify/runtime with @fedify/vocab-tools#458dahlia merged 71 commits intofedify-dev:nextfrom
@fedify/fedify/runtime with @fedify/vocab-tools#458Conversation
Summary of ChangesHello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's architecture by separating the Activity Vocabulary code generation utilities into a new, independent package named Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively separates the code generation utilities into a new @fedify/vocab-tools package, which is a great step towards better modularity. The refactoring is well-executed, with most changes involving moving files and updating paths. I've identified a couple of minor issues: a small error in the documentation and a potential unhandled error in the new CLI command. Overall, this is a solid improvement to the project structure.
…to vocab/tools
|
The docs for this pull request have been published: |
dahlia
left a comment
There was a problem hiding this comment.
The CLI is broken in Node.js; try the below commands:
cd packages/cli/
pnpm run runnode:internal/modules/package_json_reader:266
throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@fedify/vocab-tools' imported from /.../packages/cli/dist/generate-vocab/action.js
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:266:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at #cachedDefaultResolve (node:internal/modules/esm/loader:731:20)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:310:38)
at ModuleJob._link (node:internal/modules/esm/module_job:183:49) {
code: 'ERR_MODULE_NOT_FOUND'
}
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
5727d52 to
5db104d
Compare
2chanhaeng
left a comment
There was a problem hiding this comment.
- Fixed
schema.yamlto be added to the build file - Added path-related arguments to
generate-vocab
5db104d to
8d28418
Compare
Documents the extraction of vocabulary code generation tools from the main @fedify/fedify package into the new @fedify/vocab-tools package, and the addition of the `fedify generate-vocab` CLI command. This addresses #444 and documents changes from #458. Co-Authored-By: Claude <noreply@anthropic.com>
Separated `@fedify/fedify/runtime` with `@fedify/vocab-tools`
Summary
Separated
@fedify/fedify/codegento@fedify/vocab-tools.Related Issue
Changes
packages/fedify/src/codegentopackages/vocab-tools.Benefits
This PR improve modularity and extend Activity Vocabulary with custom types or use the vocabulary in non-Deno environments.
Checklist
deno task test-allon your machine?Additional Notes