Skip to content

Fix broken TravisCI deploy#250

Merged
leouieda merged 1 commit intomasterfrom
travis-is-a-lier
Apr 6, 2020
Merged

Fix broken TravisCI deploy#250
leouieda merged 1 commit intomasterfrom
travis-is-a-lier

Conversation

@leouieda
Copy link
Member

@leouieda leouieda commented Apr 6, 2020

The docs and configuration validation tool had recommended using
cleanup: false instead of skip_cleanup: true when deploying. Turns
out Travis decided to ignore the new parameter and our Github Pages
deploy was broken since the docs were deleted before we could deploy.
Revert back to the old argument until Travis really removes it.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

The docs and configuration validation tool had recommended using
`cleanup: false` instead of `skip_cleanup: true` when deploying. Turns
out Travis decided to ignore the new parameter and our Github Pages
deploy was broken since the docs were deleted before we could deploy.
Revert back to the old argument until Travis really removes it.
@leouieda leouieda merged commit 9884a27 into master Apr 6, 2020
@leouieda leouieda deleted the travis-is-a-lier branch April 6, 2020 17:18
weiji14 added a commit to GenericMappingTools/pygmt that referenced this pull request Apr 9, 2020
Revert #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
weiji14 added a commit to GenericMappingTools/pygmt that referenced this pull request Apr 9, 2020
Revert some aspects of #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
weiji14 added a commit to GenericMappingTools/pygmt that referenced this pull request Apr 10, 2020
Revert some aspects of #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant