Conversation
The docs and configuration validation tool had recommended using `cleanup: false` instead of `skip_cleanup: true` when deploying. Turns out Travis decided to ignore the new parameter and our Github Pages deploy was broken since the docs were deleted before we could deploy. Revert back to the old argument until Travis really removes it.
weiji14
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
Apr 9, 2020
Revert #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
weiji14
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
Apr 9, 2020
Revert some aspects of #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
5 tasks
weiji14
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
Apr 10, 2020
Revert some aspects of #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs and configuration validation tool had recommended using
cleanup: falseinstead ofskip_cleanup: truewhen deploying. Turnsout Travis decided to ignore the new parameter and our Github Pages
deploy was broken since the docs were deleted before we could deploy.
Revert back to the old argument until Travis really removes it.
Reminders:
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rstand the base__init__.pyfile for the package.AUTHORS.mdfile (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.