Skip to content

Remove attributes argument from check_is_fitted#217

Merged
leouieda merged 1 commit intomasterfrom
check_is_fitted
Jan 9, 2020
Merged

Remove attributes argument from check_is_fitted#217
leouieda merged 1 commit intomasterfrom
check_is_fitted

Conversation

@santisoler
Copy link
Copy Markdown
Member

The attributes argument for the sklearn.utils.validation.check_is_fitted
function is going to be deprecated. Remove the attributes passed to the
check_is_fitted function used on the predict method of every predictor
from Verde. Modify the example on verde.base.BaseGridder to show how the
check_is_fitted function must be used when subclassing the BaseGridder.

Fixes #216

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

The attributes argument for the sklearn.utils.validation.check_is_fitted
function is going to be deprecated. Remove the attributes passed to the
check_is_fitted function used on the predict method of every predictor
from Verde. Modify the example on verde.base.BaseGridder to show how the
check_is_fitted function must be used when subclassing the BaseGridder.
@santisoler santisoler requested a review from leouieda December 12, 2019 18:42
@leouieda leouieda merged commit a04d561 into master Jan 9, 2020
@leouieda leouieda deleted the check_is_fitted branch January 9, 2020 09:56
leouieda added a commit that referenced this pull request Jan 16, 2020
leouieda added a commit that referenced this pull request Jan 16, 2020
Rollback the changes in #217 because scikit-learn reverted the deprecation of
attributes in check_is_fitted. See scikit-learn/scikit-learn#15947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated attributes argument on check_is_fitted()

2 participants