Remove attributes argument from check_is_fitted#217
Merged
Conversation
The attributes argument for the sklearn.utils.validation.check_is_fitted function is going to be deprecated. Remove the attributes passed to the check_is_fitted function used on the predict method of every predictor from Verde. Modify the example on verde.base.BaseGridder to show how the check_is_fitted function must be used when subclassing the BaseGridder.
leouieda
approved these changes
Jan 9, 2020
leouieda
added a commit
that referenced
this pull request
Jan 16, 2020
Rollback the changes in #217 because scikit-learn reverted the deprecation of attributes in check_is_fitted. See scikit-learn/scikit-learn#15947
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attributes argument for the sklearn.utils.validation.check_is_fitted
function is going to be deprecated. Remove the attributes passed to the
check_is_fitted function used on the predict method of every predictor
from Verde. Modify the example on verde.base.BaseGridder to show how the
check_is_fitted function must be used when subclassing the BaseGridder.
Fixes #216
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rstandverde/__init__.py.