Conversation
|
I'm keeping the |
|
Now that I think about it, I would probably organize the CI workflows differently:
This way we avoid having multiple duplicate builds of the docs. We could still build on all systems but I think it would be fine to only run it on ubuntu. |
|
This looks great @leouieda! It's awesome to be capable of running tests on multiple Python versions locally without too much hassle. For some reason my computer is skipping the py3.6 test: Do you know why? I did notice that even if you set up your conda environment, if you try to run |
Actually there is: Buuuut be very careful. If you run Maybe we can open an Issue on their repository for this. |
santisoler
left a comment
There was a problem hiding this comment.
I left some suggestions down here. I'm not entirely convinced about nox, but I like the idea! I think I just need to spend some time with it to get used to it.
|
About running offline:
The default is making fresh environments but we can reverse that by setting |
|
Alright, with the new file after 08e23c4 you can now:
Need to add these instructions to the docstring still. |
|
@santisoler if you could give this a try locally that would be very helpful. See if you like it and if there are any other pain points we can try to resolve |
santisoler
left a comment
There was a problem hiding this comment.
This is looking great @leouieda!
I'm linking the simplicity of nox (and writing workflows in Python is much easier for me than writing Makefiles). I added some suggestions, please see if you like them.
I would like to add a few make targets:
make nox-install: for creating the virtual environments and installing dependencies (leaving everything ready for offline runs).make nox-clean: for cleaning the.noxdirectory.make nox-update: for cleaning and then installing the environments. I think this might be useful not only for offline runs but also for updating any old-dated nox environments.
Also, I would like to add a serve session for serving the built docs locally.
Let me know what do you think.
Now conda-forge has nox for 3.9 already
Also add instructions for using the noxfile in the docstring.
|
@santisoler I made a few changes:
What do you think? |
|
This is looking great!
I like that we can list all the available targets with
Much better than before!
Sure, I was thinking to add the I think this is ready to go! Nice work @leouieda ! |
It's not really needed to run the package once installed.
|
Thanks @santisoler! Merging this in. I'll work on a follow up to organize the CIs a bit. Only thing I changed is that |
Nox is a tool that automates setting up virtual environments and running tasks inside them. It's a combination of
makeand virtual environments. Replace the machinery in ourMakefile(which wouldn't work on Windows) with a cross-platformnoxfile.py. Since nox handles the virtual environments, theenvironment.ymlonly needs to have python and nox. Plus, the environment creation code in the CI is no necessary anymore and we can run tests on multiple python versions locally as well.Reminders:
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rstand the base__init__.pyfile for the package.AUTHORS.mdfile (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.