Skip to content

Use constants instead of magic numbers#90

Merged
Eomm merged 1 commit intomasterfrom
constants
Nov 18, 2023
Merged

Use constants instead of magic numbers#90
Eomm merged 1 commit intomasterfrom
constants

Conversation

@jsumners
Copy link
Member

This is a follow-up to #89. Instead of using magic numbers when setting and checking state, we use labeled constants.

@jsumners jsumners requested a review from Eomm November 18, 2023 13:44
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm Eomm merged commit c56e1e8 into master Nov 18, 2023
@Eomm Eomm deleted the constants branch November 18, 2023 15:28
@jsumners jsumners mentioned this pull request Nov 20, 2023
Eomm added a commit that referenced this pull request Dec 2, 2023
Eomm added a commit that referenced this pull request Dec 2, 2023
* Revert "Use constants instead of magic numbers (#90)"

This reverts commit c56e1e8.

* Revert "fix: avoid global unlimited config (#89)"

This reverts commit d455a6e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants