Skip to content

ci: remove node16 and 18#119

Merged
Eomm merged 1 commit intomainfrom
no16
Mar 2, 2025
Merged

ci: remove node16 and 18#119
Eomm merged 1 commit intomainfrom
no16

Conversation

@Eomm
Copy link
Member

@Eomm Eomm commented Mar 1, 2025

Same as fastify/fast-content-type-parse#47

Do we want to support node 16 18?
I think this is a leftover from #104
and we shipped a wrong version of fastify-workflow, for this reason the pin

cc @gurgunday

Signed-off-by: Manuel Spigolon <manuel.spigolon@nearform.com>
@Eomm Eomm mentioned this pull request Mar 1, 2025
4 tasks
@Fdawgs Fdawgs requested a review from a team March 1, 2025 08:45
@mcollina
Copy link
Member

mcollina commented Mar 1, 2025

I'm ok with removing, but we'd need to bump a major.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason as:

fastify/fast-content-type-parse#47 (review)

I'm fine with removing these

@Eomm Eomm merged commit 1b8c4c6 into main Mar 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants