Conversation
Signed-off-by: Manuel Spigolon <manuel.spigolon@nearform.com>
This was referenced Mar 1, 2025
gurgunday
reviewed
Mar 1, 2025
gurgunday
approved these changes
Mar 1, 2025
Fdawgs
approved these changes
Mar 1, 2025
mcollina
approved these changes
Mar 1, 2025
Member
mcollina
left a comment
There was a problem hiding this comment.
lgtm
We should bump the major
Member
Author
Yes, but: if someone would open an issue complaining that the module does not work on node16 in a specific use case, would someone work on it? Following the node.js release schedule and EOL, forces our software to be up to date with endless benefits. |
This was referenced Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line was introduced at: #31
I think this is a leftover from v1.
How do we want to ship this change?
cc @Uzlopak