Skip to content

use tape#95

Merged
mcollina merged 6 commits intofastify:mainfrom
gurgunday:tape
Jun 27, 2024
Merged

use tape#95
mcollina merged 6 commits intofastify:mainfrom
gurgunday:tape

Conversation

@gurgunday
Copy link
Member

I replace-all'd a lot of things so let me know if I missed anything important

@gurgunday gurgunday requested review from a team and mcollina June 27, 2024 11:14
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add back Node.js v16?

@gurgunday
Copy link
Member Author

@gurgunday
Copy link
Member Author

I added node 22

@gurgunday gurgunday requested a review from mcollina June 27, 2024 12:08
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0655453 into fastify:main Jun 27, 2024
@gurgunday gurgunday deleted the tape branch June 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants