Skip to content

ci(ci): drop node 18#268

Merged
Fdawgs merged 1 commit intomainfrom
Fdawgs-patch-1
Apr 2, 2025
Merged

ci(ci): drop node 18#268
Fdawgs merged 1 commit intomainfrom
Fdawgs-patch-1

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Mar 5, 2025

Similar to fastify/fast-content-type-parse#47.
Node 18 is EOL next month, so we should drop it.

Breaking change so will need a major release.

Checklist

Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
@Fdawgs Fdawgs requested a review from a team March 8, 2025 12:01
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Wdyt @aboutlo?

@Fdawgs
Copy link
Member Author

Fdawgs commented Apr 2, 2025

@mcollina You happy for me to merge without input from @aboutlo? It's been almost a month.

@mcollina
Copy link
Member

mcollina commented Apr 2, 2025

Yes,let's do it.

@Fdawgs Fdawgs merged commit 588df8a into main Apr 2, 2025
13 checks passed
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch April 2, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants