chore(tests): replaced jest with node:test#245
Merged
gurgunday merged 2 commits intofastify:nextfrom Jun 6, 2024
Merged
Conversation
Contributor
|
@mcollina build is failing on Node 16, I suspect something incompatible with c8 or even node:test. Are we supposed to still support Node 16 with this library? |
gurgunday
reviewed
Jun 6, 2024
Member
gurgunday
left a comment
There was a problem hiding this comment.
Please target next and modify this line to test only on 18, 20, 22:
595b4b5 to
0bac57b
Compare
Collaborator
|
Thank you for this @floridemai 🙌 |
Member
|
We can just drop node.js v16 |
Member
I think to keep things organized we should keep CI changes in |
Member
|
Thanks a lot for the PR! |
jsumners
pushed a commit
that referenced
this pull request
Jun 18, 2024
* chore(tests): replaced jest with node:test * chore: removed node 16 from version targets
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243
Updated all test files to work with
node:testrunner. Everything went smooth with only two notes: certain expected objects needed and addiional$id: undefinedproperty and a test where the error type was invalid.Checklist
npm run testandnpm run benchmarkand the Code of conduct