Merged
Conversation
climba03003
requested changes
Jul 21, 2022
Member
climba03003
left a comment
There was a problem hiding this comment.
Can you document the option?
Contributor
Author
|
@climba03003 |
Member
What I request is actually document how I think it is suitable to explain in the format below. |
Contributor
Author
|
@climba03003 |
Uzlopak
added a commit
to Uzlopak/fastify-cookie
that referenced
this pull request
Jul 25, 2022
* add secure: auto Option * document deviation from cookie serialize * describe better * lowercase Lax
Uzlopak
added a commit
that referenced
this pull request
Aug 11, 2022
* integrate cookie signer * add algorithm as plugin-option * check for matching error message * improve tests * remove unnecessary array conversion * simplify * fix comment * restructure SignerFactory * update typings * fix exports * add benchmarks * improve perf for multi secrets * rename SignerFactory to Signer * Merge branch 'master' into integrate-cookie-signer * export signerFactory * Update signer.js * add secure: 'auto' Option (#199) * add secure: auto Option * document deviation from cookie serialize * describe better * lowercase Lax * Bumped v7.3.0 Signed-off-by: Matteo Collina <hello@matteocollina.com> * make type definitons `"module": "nodenext"` compatible (#184) * make type definitons `"module": "nodenext"` compatible * see microsoft/TypeScript#48845 * fix test * fix default export type * make typing extra safe and small refactoring * restore brackets * add additional properties to named export and fix test suite * remove formatting * revert formatting * reuse type * Bumped v7.3.1 Signed-off-by: Matteo Collina <hello@matteocollina.com> * modify types * remove dummy * fix regex bottleneck found by sonarqube Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Volodymyr Zhdanov <wight554@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality is basically taken from @fastify/session https://github.com/fastify/session/blob/b1fc11c6fbb16c63a1884f202fcd030ecdb18a07/lib/cookie.js#L17
On the long run, we can remove the cookie class from @fastify/session.
Checklist
npm run testandnpm run benchmarkand the Code of conduct