Merged
Conversation
Eomm
reviewed
May 5, 2025
Member
Eomm
left a comment
There was a problem hiding this comment.
:O we were not doing it everywhere.
We should add it to the .npmrc file so we don't must remember to do it on the next npm install script:
ignore-scripts=true
(the arg must stay for other package manages I think)
metcoder95
approved these changes
May 6, 2025
jean-michelet
pushed a commit
to jean-michelet/fastify
that referenced
this pull request
May 13, 2025
* ci: ignore scripts * chore(.npmrc): ignore scripts
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
--ignore-scriptsarg to disable the execution of any scripts by third-party packages.See https://snyk.io/blog/npm-security-preventing-supply-chain-attacks/
Checklist
and the Code of conduct