Skip to content

feat: add mkcalendar and report methods#5439

Merged
mcollina merged 3 commits intofastify:mainfrom
keyservlad:mkcalendar-and-report-methods
May 3, 2024
Merged

feat: add mkcalendar and report methods#5439
mcollina merged 3 commits intofastify:mainfrom
keyservlad:mkcalendar-and-report-methods

Conversation

@keyservlad
Copy link
Contributor

Related to #9 and PR #3836

Includes support for MKCALENDAR and REPORT methods which are both part of the webDAV protocol.

I need to use these methods in a project that deals with contacts and calendars sync (CARDDAV / CALDAV).

Checklist

@gurgunday
Copy link
Member

Support for MKCALENDAR on the server is only RECOMMENDED and not REQUIRED

Just adding context, but it’s fine I think

@gurgunday
Copy link
Member

Do you know if there are other missing methods

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keyservlad
Copy link
Contributor Author

Do you know if there are other missing methods

Not that we are using them in my project but i'm aware there are some like MKACTIVITY, MERGE, ACL...
Imo it might be a good idea to check out what we are missing in require('http').METHODS

[ 'ACL', 'BIND', 'CHECKOUT', 'CONNECT', 'COPY', 'DELETE', 'GET', 'HEAD', 'LINK', 'LOCK', 'M-SEARCH', 'MERGE', 'MKACTIVITY', 'MKCALENDAR', 'MKCOL', 'MOVE', 'NOTIFY', 'OPTIONS', 'PATCH', 'POST', 'PROPFIND', 'PROPPATCH', 'PURGE', 'PUT', 'REBIND', 'REPORT', 'SEARCH', 'SOURCE', 'SUBSCRIBE', 'TRACE', 'UNBIND', 'UNLINK', 'UNLOCK', 'UNSUBSCRIBE' ]

Although this has already been discussed: #9 (comment)

@metcoder95
Copy link
Member

Tests seems failing

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina mcollina merged commit bf64e47 into fastify:main May 3, 2024
@gurgunday
Copy link
Member

@keyservlad can you open a PR to next to add them there as well?

const bodyMethods = new Set([
// Standard
'DELETE',
'OPTIONS',
'PATCH',
'PUT',
'POST',
// WebDAV
'COPY',
'LOCK',
'MOVE',
'MKCOL',
'PROPFIND',
'PROPPATCH',
'SEARCH'
])

@keyservlad
Copy link
Contributor Author

@keyservlad can you open a PR to next to add them there as well?

const bodyMethods = new Set([
// Standard
'DELETE',
'OPTIONS',
'PATCH',
'PUT',
'POST',
// WebDAV
'COPY',
'LOCK',
'MOVE',
'MKCOL',
'PROPFIND',
'PROPPATCH',
'SEARCH'
])

Hey @gurgunday i just created the new pr #5444 but for some reason some tests are failing if you can help me figuring out why ¯_(ツ)_/¯

@github-actions
Copy link

github-actions bot commented May 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants