feat: add webdav http methods#3836
feat: add webdav http methods#3836mcollina merged 11 commits intofastify:mainfrom hungtcs:webdav-methods
Conversation
|
Do those method accept a body? Can you please test like the other methods are tested? Those methods are not that common, I would not add the shorthands. |
|
@mcollina Yes, some method receive a body of type xml sometimes, I will adjust some details later. |
the vscode plugin automatically updated the directory
- remove webdav method shorthand
|
Looks like it's almost done, but before merging, I will write a simple WebDAV server for real world test. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
| @@ -0,0 +1,22 @@ | |||
| 'use strict' | |||
|
|
|||
There was a problem hiding this comment.
Maybe it's would be better to split the supported methods into 2 arrays. it helps when we like to provide an option for enabling/disabling the WebDAV methods...
const baseHtttpMethods = ['DELETE', 'GET', 'HEAD', 'PATCH', 'POST', 'PUT', 'OPTIONS']
const webDAVHtttpMethods = ['PROPFIND', 'PROPPATCH', 'MKCOL', 'COPY', 'MOVE', 'LOCK', 'UNLOCK', 'TRACE', 'SEARCH']
module.exports = {
supportedMethods: [...baseHtttpMethods, ...webDAVHtttpMethods] // you can use concat or whatever!
}|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Relat #9
Checklist
npm run testandnpm run benchmarkand the Code of conduct