fix: Set FastifyRequest.id type as a string#4992
Merged
Uzlopak merged 1 commit intofastify:mainfrom Aug 26, 2023
Merged
Conversation
FastifyRequest.id type as a string
Member
|
ID might not be string since it is the output of the generate id function. |
Member
On types, we somehow make it explicit that the function should return a |
Contributor
|
No runtime validation/casting please. genReqId option for the fastify constructor defines the function as returning a string. So if somebody provides a custom genReqId which is not returning a string, then this violates our "api contract" already. |
Member
|
No strong opinion about it, so it SGTM 👍 |
Member
Just wanna +1 this especially when it comes to Fastify since zero overhead is a core principle – that the type definitions are there for a reason and breaking that contract will naturally introduce unexpected behavior, weather it is in the form of errors or something else |
Eomm
approved these changes
Aug 25, 2023
Member
Eomm
left a comment
There was a problem hiding this comment.
ID might not be string since it is the output of the generate id function.
Correct, but:
- by default it is a string
- if user customizes it, it reads from headers 99% of the times, so it is a string
renovate bot
referenced
this pull request
in tomacheese/telcheck
Aug 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.21.0` -> `4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0) #### What's Changed - make FastifySchemaValidationError.params wider by [@​cm-ayf](https://togithub.com/cm-ayf) in [https://github.com/fastify/fastify/pull/4476](https://togithub.com/fastify/fastify/pull/4476) - docs(ecosystem): add fastify-hashids by [@​andersonjoseph](https://togithub.com/andersonjoseph) in [https://github.com/fastify/fastify/pull/4934](https://togithub.com/fastify/fastify/pull/4934) - fix: hasPlugin does not track parent plugins by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/4929](https://togithub.com/fastify/fastify/pull/4929) - docs: early hints plugin is fastify plugin by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4947](https://togithub.com/fastify/fastify/pull/4947) - chore: add pull request title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4951](https://togithub.com/fastify/fastify/pull/4951) - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.29.6 to 0.30.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4952](https://togithub.com/fastify/fastify/pull/4952) - ci: improve pr title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4953](https://togithub.com/fastify/fastify/pull/4953) - ci: fix warnings in benchmark workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4954](https://togithub.com/fastify/fastify/pull/4954) - docs: fix removeAdditional comment by [@​G0maa](https://togithub.com/G0maa) in [https://github.com/fastify/fastify/pull/4948](https://togithub.com/fastify/fastify/pull/4948) - fix: Try to fix parser benchmark workflow by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/fastify/fastify/pull/4956](https://togithub.com/fastify/fastify/pull/4956) - fix: infer correct hook handler by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4945](https://togithub.com/fastify/fastify/pull/4945) - fix: do not double send the response if the request is destroyed but not aborted by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4963](https://togithub.com/fastify/fastify/pull/4963) - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.30.4 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4973](https://togithub.com/fastify/fastify/pull/4973) - fix: bodyLimit must be applied on fully decoded body by [@​sergburn](https://togithub.com/sergburn) in [https://github.com/fastify/fastify/pull/4969](https://togithub.com/fastify/fastify/pull/4969) - chore: updates [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) and [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4977](https://togithub.com/fastify/fastify/pull/4977) - chore: use group dependencies in dependabot by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4979](https://togithub.com/fastify/fastify/pull/4979) - chore: fix ci bench by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/4983](https://togithub.com/fastify/fastify/pull/4983) - fix: require.cache is undefined breaks SEA by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4982](https://togithub.com/fastify/fastify/pull/4982) - ci: remove sync next wf by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4985](https://togithub.com/fastify/fastify/pull/4985) - docs: remove mixing ES6 and commomjs in the example by [@​thenicolau](https://togithub.com/thenicolau) in [https://github.com/fastify/fastify/pull/4990](https://togithub.com/fastify/fastify/pull/4990) - fix: errorHandler callback should utilize TypeProvider by [@​muan](https://togithub.com/muan) in [https://github.com/fastify/fastify/pull/4989](https://togithub.com/fastify/fastify/pull/4989) - types: add onRoute to ApplicationHookLookup by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4968](https://togithub.com/fastify/fastify/pull/4968) - chore: make tests pass on ipv4 only machine by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4997](https://togithub.com/fastify/fastify/pull/4997) - fix: Set `FastifyRequest.id` type as a string by [@​samchungy](https://togithub.com/samchungy) in [https://github.com/fastify/fastify/pull/4992](https://togithub.com/fastify/fastify/pull/4992) #### New Contributors - [@​G0maa](https://togithub.com/G0maa) made their first contribution in [https://github.com/fastify/fastify/pull/4948](https://togithub.com/fastify/fastify/pull/4948) - [@​thenicolau](https://togithub.com/thenicolau) made their first contribution in [https://github.com/fastify/fastify/pull/4990](https://togithub.com/fastify/fastify/pull/4990) - [@​muan](https://togithub.com/muan) made their first contribution in [https://github.com/fastify/fastify/pull/4989](https://togithub.com/fastify/fastify/pull/4989) - [@​samchungy](https://togithub.com/samchungy) made their first contribution in [https://github.com/fastify/fastify/pull/4992](https://togithub.com/fastify/fastify/pull/4992) **Full Changelog**: fastify/fastify@v4.21.0...v4.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Uzlopak
added a commit
that referenced
this pull request
Aug 29, 2023
* New plugin rabbitmq (#1) * Update Ecosystem.md * added my plugin * chore: make tests pass on ipv4 only machine (#4997) Signed-off-by: Matteo Collina <hello@matteocollina.com> * fix: type FastifyRequest id as a string (#4992) * Bumped v4.22.0 Signed-off-by: Matteo Collina <hello@matteocollina.com> --------- Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Sam Chung <samchungy@gmail.com> * fix --------- Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Sam Chung <samchungy@gmail.com> Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
renovate bot
referenced
this pull request
in redwoodjs/graphql
Aug 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.21.0` -> `4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0) ##### What's Changed - make FastifySchemaValidationError.params wider by [@​cm-ayf](https://togithub.com/cm-ayf) in [https://github.com/fastify/fastify/pull/4476](https://togithub.com/fastify/fastify/pull/4476) - docs(ecosystem): add fastify-hashids by [@​andersonjoseph](https://togithub.com/andersonjoseph) in [https://github.com/fastify/fastify/pull/4934](https://togithub.com/fastify/fastify/pull/4934) - fix: hasPlugin does not track parent plugins by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/4929](https://togithub.com/fastify/fastify/pull/4929) - docs: early hints plugin is fastify plugin by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4947](https://togithub.com/fastify/fastify/pull/4947) - chore: add pull request title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4951](https://togithub.com/fastify/fastify/pull/4951) - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.29.6 to 0.30.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4952](https://togithub.com/fastify/fastify/pull/4952) - ci: improve pr title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4953](https://togithub.com/fastify/fastify/pull/4953) - ci: fix warnings in benchmark workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4954](https://togithub.com/fastify/fastify/pull/4954) - docs: fix removeAdditional comment by [@​G0maa](https://togithub.com/G0maa) in [https://github.com/fastify/fastify/pull/4948](https://togithub.com/fastify/fastify/pull/4948) - fix: Try to fix parser benchmark workflow by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/fastify/fastify/pull/4956](https://togithub.com/fastify/fastify/pull/4956) - fix: infer correct hook handler by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4945](https://togithub.com/fastify/fastify/pull/4945) - fix: do not double send the response if the request is destroyed but not aborted by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4963](https://togithub.com/fastify/fastify/pull/4963) - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.30.4 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4973](https://togithub.com/fastify/fastify/pull/4973) - fix: bodyLimit must be applied on fully decoded body by [@​sergburn](https://togithub.com/sergburn) in [https://github.com/fastify/fastify/pull/4969](https://togithub.com/fastify/fastify/pull/4969) - chore: updates [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) and [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4977](https://togithub.com/fastify/fastify/pull/4977) - chore: use group dependencies in dependabot by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4979](https://togithub.com/fastify/fastify/pull/4979) - chore: fix ci bench by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/4983](https://togithub.com/fastify/fastify/pull/4983) - fix: require.cache is undefined breaks SEA by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4982](https://togithub.com/fastify/fastify/pull/4982) - ci: remove sync next wf by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4985](https://togithub.com/fastify/fastify/pull/4985) - docs: remove mixing ES6 and commomjs in the example by [@​thenicolau](https://togithub.com/thenicolau) in [https://github.com/fastify/fastify/pull/4990](https://togithub.com/fastify/fastify/pull/4990) - fix: errorHandler callback should utilize TypeProvider by [@​muan](https://togithub.com/muan) in [https://github.com/fastify/fastify/pull/4989](https://togithub.com/fastify/fastify/pull/4989) - types: add onRoute to ApplicationHookLookup by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4968](https://togithub.com/fastify/fastify/pull/4968) - chore: make tests pass on ipv4 only machine by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4997](https://togithub.com/fastify/fastify/pull/4997) - fix: Set `FastifyRequest.id` type as a string by [@​samchungy](https://togithub.com/samchungy) in [https://github.com/fastify/fastify/pull/4992](https://togithub.com/fastify/fastify/pull/4992) ##### New Contributors - [@​G0maa](https://togithub.com/G0maa) made their first contribution in [https://github.com/fastify/fastify/pull/4948](https://togithub.com/fastify/fastify/pull/4948) - [@​thenicolau](https://togithub.com/thenicolau) made their first contribution in [https://github.com/fastify/fastify/pull/4990](https://togithub.com/fastify/fastify/pull/4990) - [@​muan](https://togithub.com/muan) made their first contribution in [https://github.com/fastify/fastify/pull/4989](https://togithub.com/fastify/fastify/pull/4989) - [@​samchungy](https://togithub.com/samchungy) made their first contribution in [https://github.com/fastify/fastify/pull/4992](https://togithub.com/fastify/fastify/pull/4992) **Full Changelog**: fastify/fastify@v4.21.0...v4.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
referenced
this pull request
in redwoodjs/graphql
Sep 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.21.0` -> `4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0) ##### What's Changed - make FastifySchemaValidationError.params wider by [@​cm-ayf](https://togithub.com/cm-ayf) in [https://github.com/fastify/fastify/pull/4476](https://togithub.com/fastify/fastify/pull/4476) - docs(ecosystem): add fastify-hashids by [@​andersonjoseph](https://togithub.com/andersonjoseph) in [https://github.com/fastify/fastify/pull/4934](https://togithub.com/fastify/fastify/pull/4934) - fix: hasPlugin does not track parent plugins by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/4929](https://togithub.com/fastify/fastify/pull/4929) - docs: early hints plugin is fastify plugin by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4947](https://togithub.com/fastify/fastify/pull/4947) - chore: add pull request title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4951](https://togithub.com/fastify/fastify/pull/4951) - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.29.6 to 0.30.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4952](https://togithub.com/fastify/fastify/pull/4952) - ci: improve pr title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4953](https://togithub.com/fastify/fastify/pull/4953) - ci: fix warnings in benchmark workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4954](https://togithub.com/fastify/fastify/pull/4954) - docs: fix removeAdditional comment by [@​G0maa](https://togithub.com/G0maa) in [https://github.com/fastify/fastify/pull/4948](https://togithub.com/fastify/fastify/pull/4948) - fix: Try to fix parser benchmark workflow by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/fastify/fastify/pull/4956](https://togithub.com/fastify/fastify/pull/4956) - fix: infer correct hook handler by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4945](https://togithub.com/fastify/fastify/pull/4945) - fix: do not double send the response if the request is destroyed but not aborted by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4963](https://togithub.com/fastify/fastify/pull/4963) - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.30.4 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4973](https://togithub.com/fastify/fastify/pull/4973) - fix: bodyLimit must be applied on fully decoded body by [@​sergburn](https://togithub.com/sergburn) in [https://github.com/fastify/fastify/pull/4969](https://togithub.com/fastify/fastify/pull/4969) - chore: updates [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) and [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4977](https://togithub.com/fastify/fastify/pull/4977) - chore: use group dependencies in dependabot by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4979](https://togithub.com/fastify/fastify/pull/4979) - chore: fix ci bench by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/4983](https://togithub.com/fastify/fastify/pull/4983) - fix: require.cache is undefined breaks SEA by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4982](https://togithub.com/fastify/fastify/pull/4982) - ci: remove sync next wf by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4985](https://togithub.com/fastify/fastify/pull/4985) - docs: remove mixing ES6 and commomjs in the example by [@​thenicolau](https://togithub.com/thenicolau) in [https://github.com/fastify/fastify/pull/4990](https://togithub.com/fastify/fastify/pull/4990) - fix: errorHandler callback should utilize TypeProvider by [@​muan](https://togithub.com/muan) in [https://github.com/fastify/fastify/pull/4989](https://togithub.com/fastify/fastify/pull/4989) - types: add onRoute to ApplicationHookLookup by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4968](https://togithub.com/fastify/fastify/pull/4968) - chore: make tests pass on ipv4 only machine by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4997](https://togithub.com/fastify/fastify/pull/4997) - fix: Set `FastifyRequest.id` type as a string by [@​samchungy](https://togithub.com/samchungy) in [https://github.com/fastify/fastify/pull/4992](https://togithub.com/fastify/fastify/pull/4992) ##### New Contributors - [@​G0maa](https://togithub.com/G0maa) made their first contribution in [https://github.com/fastify/fastify/pull/4948](https://togithub.com/fastify/fastify/pull/4948) - [@​thenicolau](https://togithub.com/thenicolau) made their first contribution in [https://github.com/fastify/fastify/pull/4990](https://togithub.com/fastify/fastify/pull/4990) - [@​muan](https://togithub.com/muan) made their first contribution in [https://github.com/fastify/fastify/pull/4989](https://togithub.com/fastify/fastify/pull/4989) - [@​samchungy](https://togithub.com/samchungy) made their first contribution in [https://github.com/fastify/fastify/pull/4992](https://togithub.com/fastify/fastify/pull/4992) **Full Changelog**: fastify/fastify@v4.21.0...v4.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4993