fix route hooks typings#4628
Closed
aradwann wants to merge 3 commits intofastify:mainfrom
aradwann:fix-route-hooks-typings
Closed
fix route hooks typings#4628aradwann wants to merge 3 commits intofastify:mainfrom aradwann:fix-route-hooks-typings
aradwann wants to merge 3 commits intofastify:mainfrom
aradwann:fix-route-hooks-typings
Conversation
mcollina
approved these changes
Mar 14, 2023
mcollina
requested changes
Mar 14, 2023
Member
mcollina
left a comment
There was a problem hiding this comment.
The types are still incorrect.
The hook system support either the use of promises or callbacks, but not both at the same time:
async (req, reply) => {}
or
`(req, reply. done) => {}
mcollina
requested changes
Mar 25, 2023
| method: 'GET', | ||
| url: '/', | ||
| handler: () => { }, | ||
| onRequest: async (request, reply, done) => { |
Member
There was a problem hiding this comment.
This is incorrect. When async is specified there should be no done callback.
Contributor
There was a problem hiding this comment.
Jees, why is the guy adding done or error payload in the code even when they are not being used in the function body?
If possible, can I correct this one?
JbIPS
added a commit
to JbIPS/fastify
that referenced
this pull request
Apr 3, 2023
Based on PR fastify#4628 with signature fixed Closes fastify#4376
4 tasks
JbIPS
added a commit
to JbIPS/fastify
that referenced
this pull request
Apr 5, 2023
Based on PR fastify#4628 with signature fixed Closes fastify#4376
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
fixes #4376 and #4595